fix: add back rules for import/first and import/order (#118)

BREAKING CHANGE: import first added back, so breaking from previous version that disabled it implicitely
BREAKING CHANGE: added import ordering

Co-authored-by: Benjamin SÉGAULT <Benjamin Ségault 8903454+bsegault@users.noreply.github.com>

.eslintrc.js

@@ -65,6 +65,22 @@ module.exports = {
     // Enforced
     //
     curly: "warn",
+    // Force import first
+    "import/first": "warn",
+    "import/order": [
+      "warn",
+      {
+        groups: ["builtin", "external"],
+        pathGroups: [
+          {
+            pattern: "@epconnect/**",
+            group: "external",
+            position: "after",
+          },
+        ],
+        "newlines-between": "always-and-inside-groups",
+      },
+    ],
     // Set console calls to emit warnings as not enabled by eslint:recommended
     "no-console": "warn",
     // enforce types

config.json

@@ -18,19 +18,41 @@
     "project": "./tsconfig.json"
   },
   "plugins": [
-    "@typescript-eslint",
     "sonarjs",
     "react-hooks",
     "react",
     "jsx-a11y",
     "import",
-    "flowtype"
+    "flowtype",
+    "@typescript-eslint"
   ],
   "reportUnusedDisableDirectives": true,
   "rules": {
     "curly": [
       "warn"
     ],
+    "import/first": [
+      "warn"
+    ],
+    "import/order": [
+      "warn",
+      {
+        "groups": [
+          "builtin",
+          "external"
+        ],
+        "pathGroups": [
+          {
+            "pattern": "@epconnect/**",
+            "group": "external",
+            "position": "after"
+          }
+        ],
+        "newlines-between": "always-and-inside-groups",
+        "distinctGroup": true,
+        "warnOnUnassignedImports": false
+      }
+    ],
     "no-console": [
       "warn"
     ],

package.json

@@ -47,6 +47,7 @@
     "eslint-plugin-sonarjs": "^0.19.0"
   },
   "devDependencies": {
+    "@types/node": "^16.18.23",
     "conventional-changelog-conventionalcommits": "^5.0.0",
     "eslint": "^8.39.0",
     "prettier": "^2.8.8",

sandbox.ts

@@ -1,6 +1,16 @@
 // A dummy files to test manually rules
+/* eslint-disable no-console */
+
+import _json5 from "json5";
+
+const first = 0;
+
+// eslint-disable-next-line import/first
+import pkg from "./package.json";
+
+// eslint-disable-next-line import/first, import/order
+import fs from "fs";
 
-// eslint-disable-next-line no-console
 console.log("hello");
 
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
@@ -9,8 +19,9 @@ const empty = 1;
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 let dummy: any;
 
+console.log(fs.readSync);
+
 // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export const getDummy = (param: unknown) => {
-  // eslint-disable-next-line no-console
-  console.log(`${dummy} and ${param}`);
+  console.log(`${dummy} and ${param} a, ${first}, ${pkg.version}`);
 };