Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore screencast session part 1 #179

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

columbarius
Copy link
Collaborator

@columbarius columbarius commented Jan 16, 2022

First shot at implementing restoring screencast sessions.

The first part skips implementing the user facing interactive part and adds an environment variable to enable this experimental feature.

Implements #170

@columbarius columbarius added the enhancement New feature or request label Jan 16, 2022
@columbarius
Copy link
Collaborator Author

Got the dbus stuff working!

@columbarius
Copy link
Collaborator Author

Maybe this could be useful with an option to allow at least the transient mode to get rid of the annoying second query from chromium before making this available via the chooser protocol?

@Algram
Copy link
Contributor

Algram commented Jun 10, 2022

@columbarius What would be needed to get this in a mergeable state? Are there any problems left or just cleanup?

@columbarius
Copy link
Collaborator Author

@Algram This is a PoC for the dbus side. If you want a lite version of it so chromium won't show the dialog twice, this could be easily completed. To support restoring sessions after a restart of the application all the user facing dialogs needs to be done. This also requires a more complex chooser.

@Algram
Copy link
Contributor

Algram commented Jun 16, 2022

@columbarius My problem is that I am using the OBS Pipewire capturing which currently re prompts me every time I start OBS right now.

I already tried your comment here: #170 (comment) but this does not seem to remove the prompt.

@columbarius
Copy link
Collaborator Author

I already tried your comment here: #170 (comment) but this does not seem to remove the prompt.

Try restarting xdpw, or just restart your pc after changing the config. If you see still the prompt, please open a separate issue.

We don't use them anywhere else. As such this is just a removing of the
header declarations and reordering of functions.
This struct tracks the target of a screencast and is a first step to
introduce future features region selection and different target types,
as well as restore data.
This implements a shim function to use the new api without redesigning
the chooser code yet.
This struct contains data attached to a screencast session.
It will be used to support session restore and the metadata cursormode.
This is an experimental feature until a ui solution is wired up.

XDPW_PERSIST_MODE=<value>
<value>:
	"permanent": allow restoring a session permanent
	"transient": allow restoring a session while a programm runs
@columbarius columbarius marked this pull request as ready for review February 20, 2023 02:21
@columbarius columbarius changed the title [WIP]: Restore screencast session Restore screencast session part 1 Feb 20, 2023
@columbarius columbarius merged commit 1dfee26 into emersion:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants