imap: turn FetchItem into FetchOptions #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
fetch-items
branch
3 times, most recently
from
19c70da to
cf8d6b4
Compare
Will be useful to write BODY from an extended imap.BodyStructure.
adregner
added a commit
to adregner/go-imap
that referenced
this pull request
Jul 2, 2023
emersion#517 uses the new `enc.BeginList()` to encode fetch options over the IMAP protocol, but never calls `.End()` so the closing `)` character is never written out, causing errors like `T6 BAD Could not parse command`.
emersion
pushed a commit
that referenced
this pull request
Jul 2, 2023
#517 uses the new `enc.BeginList()` to encode fetch options over the IMAP protocol, but never calls `.End()` so the closing `)` character is never written out, causing errors like `T6 BAD Could not parse command`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BODYandBODYSTRUCTUREwhen both are requested