Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New geth 1.11 breaks dshackle #227

Closed
adrianchiforwm opened this issue Feb 21, 2023 · 6 comments
Closed

New geth 1.11 breaks dshackle #227

adrianchiforwm opened this issue Feb 21, 2023 · 6 comments

Comments

@adrianchiforwm
Copy link

ethereum/go-ethereum#25570
https://github.com/ethereum/go-ethereum/releases/tag/v1.11.0

Geth's JSON-RPC server has become more strict; the JSON-RPC spec requires the version field to be exactly "jsonrpc": "2.0". 
This is now verified by the server -- a change which is not backwards-compatible with non-conforming client implementations.
2023-21-02 12:09:39.493 | INFO  |  Multistream | State of ETH: height=16676781, status=[OK/3,SYNCING/1], lag=[0, 0, 0, NA], weak=[<new geth>]
2023-21-02 12:06:07.034 | INFO  | WsConnection | Connecting to WebSocket: ws://<new geth>:8546/
2023-21-02 12:06:07.465 | WARN  | WsConnection | Received error -32600 from ws://<new geth>:8546/: invalid request
2023-21-02 12:06:07.466 | WARN  | WsConnection | Received error -32600 from ws://<new geth>:8546/: invalid request
2023-21-02 12:06:07.466 | INFO  | WsConnection | Reconnect to ws://<new geth>:8546/ in 300000ms...

Looks like dshackle doesn't set the version in JSON-RPC requests so things like eth_syncing always think the node is behind (lag NA) and eth_subscribe websockets fail to establish.

cc @splix

@splix
Copy link
Member

splix commented Feb 22, 2023

Fixed in #228

@splix splix closed this as completed Feb 22, 2023
@adrianchiforwm
Copy link
Author

@splix Thanks for the quick fix! Although eth_syncing is still broken, reports NA lag - missing the jsonrpc field. Once that's fixed, can we tag a new release and docker image? So dshackle can be ready in time for Capella.

@OscBacon
Copy link

Hey, could you please push a docker image with the fix? In the meantime I'll push one on my account

@OscBacon
Copy link

Actually, would be good to share your Dockerfile to please :)

@splix
Copy link
Member

splix commented Mar 23, 2023

@OscBacon it's ./gradlew jibDockerBuild to install to a local Docker (and then docker tag/docker push) or ./gradlew jib -Pdocker=MYREMOTEDOCKERREPO to push a remote docker directly from the build

@OscBacon
Copy link

Ah thanks @splix, not too familiar with Java.
Why hold off on pushing an image with these changes by the way?

vdoflip pushed a commit to jit-strategies/dshackle that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants