Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MetaRecommender Warnings #292

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Fix MetaRecommender Warnings #292

merged 6 commits into from
Jul 3, 2024

Conversation

Scienfitz
Copy link
Collaborator

Adjustments to avoid annoying warnings

  • MetaRecommenders do not use objective and measurements arguments with NonPredictiveRecommenders anymore --> source of the warnings flood in many simulations
  • Added a custom warning to distinguish the non-predictive recommender warnings
  • Caught some expected warnings in tests

@Scienfitz Scienfitz added the enhancement Expand / change existing functionality label Jul 1, 2024
@Scienfitz Scienfitz self-assigned this Jul 1, 2024
Scienfitz
Scienfitz commented Jul 1, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
AdrianSosic
AdrianSosic reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly implementing this fix 🎖️ Just one comment

baybe/exceptions.py Outdated Show resolved Hide resolved
AVHopp
AVHopp approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like, but also agree that the name of the exception/warning should change.

@Scienfitz Scienfitz force-pushed the fix/meta_recommender_warnings branch from 0dff311 to 8885d4e Compare July 2, 2024 08:07
@Scienfitz Scienfitz force-pushed the fix/meta_recommender_warnings branch from 8885d4e to c7fe57d Compare July 3, 2024 09:22
@Scienfitz Scienfitz merged commit b359a61 into main Jul 3, 2024
10 checks passed
@Scienfitz Scienfitz deleted the fix/meta_recommender_warnings branch July 3, 2024 10:53
@Scienfitz
Copy link
Collaborator Author

@marcelmbn this possibly fixes the warnings you've been getting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianSosic AdrianSosic AdrianSosic approved these changes

@AVHopp AVHopp AVHopp approved these changes

Assignees

@Scienfitz Scienfitz

Labels
enhancement Expand / change existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scienfitz @AdrianSosic @AVHopp