Reorganize simulation lookup #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianSosic
force-pushed
the
refactor/lookup
branch
from
f90f817
to
d7c57f8
Compare
AdrianSosic
commented
Jun 12, 2024
There was a problem hiding this comment.
Hi @Scienfitz, just wanted to let you know that I've rebase the PR on top of #266, which finally cleans up our optional imports and also solves the problem that remained in this PR. So let's review the other PR first 😃
AdrianSosic
force-pushed
the
refactor/lookup
branch
2 times, most recently
from
d227c24
to
24c282b
Compare
AVHopp
reviewed
Jun 21, 2024
AdrianSosic
force-pushed
the
refactor/lookup
branch
from
24c282b
to
cfe57d8
Compare
Scienfitz
reviewed
Jun 24, 2024
AVHopp
reviewed
Jun 26, 2024
AVHopp
approved these changes
Jul 2, 2024
AdrianSosic
force-pushed
the
refactor/lookup
branch
5 times, most recently
from
b385912
to
6fe6e50
Compare
Scienfitz
approved these changes
Jul 3, 2024
AdrianSosic
force-pushed
the
refactor/lookup
branch
from
6fe6e50
to
cba049c
Compare
AdrianSosic
commented
Jul 4, 2024
AdrianSosic
force-pushed
the
refactor/lookup
branch
from
cba049c
to
379f790
Compare
AdrianSosic
force-pushed
the
refactor/lookup
branch
from
379f790
to
da8ce9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another step toward a cleaned simulation package:
Campaignso that it can be flexibly used without having to set up a campaign object first (e.g. in tests)Moves simulation-related utilities to the simulation package