Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor visual issues in the documentation #195

Open
1 of 11 tasks
AVHopp opened this issue Apr 4, 2024 · 17 comments
Open
1 of 11 tasks

Minor visual issues in the documentation #195

AVHopp opened this issue Apr 4, 2024 · 17 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@AVHopp
Copy link
Collaborator

AVHopp commented Apr 4, 2024

This issue is intended to serve as a place where minor visual issues regarding the documentation can be collected. Once enough such have been identified, they will be resolved in a corresponding PR.

Note in particular that this issue should not be used to collect major changes. Basically, if you see something in our documentation and think "Huh, that just looks a bit weird and would benefit from reformatting", then this is the place to just put it 😄

EDIT: The following issues have been identified:

  • Cut-off in the table describing the numerical parameters:
    image
  • The caching outputs in the examples should all go.
  • There are weird formatting jumps in some examples:
    image
  • Ugly table in light mode in search space userguide
  • Bad cutoff of very long pages (see eg. in df_appl_permutation_augmentation)
  • Alternative to baybe in the table of contents (NOTE: I do not think that this is possible, putting this here nevertheless)
  • Output/Warnings on console when building the documentation
  • Reduce level of toc in User Guide overview page
  • Improve visual of example plot on github README in dark mode
  • Weird formatting in the docstring of the FPS sampling:
    image

The following issues have already been fixed:

@AVHopp AVHopp added the documentation Improvements or additions to documentation label Apr 4, 2024
@AVHopp AVHopp self-assigned this Apr 4, 2024
@Scienfitz

This comment was marked as outdated.

@Scienfitz

This comment was marked as outdated.

@AVHopp
Copy link
Collaborator Author

AVHopp commented Apr 4, 2024

@Scienfitz the tqdm progress bars are already gone, which bars are you referring to?

@Scienfitz
Copy link
Collaborator

@AVHopp thats right I thought I still saw progress bars somewhere but it seems theyre gone and I probably confused some of the cache notifications with them

@Scienfitz

This comment was marked as duplicate.

@brandon-holt
Copy link
Contributor

@Scienfitz the tqdm progress bars are already gone, which bars are you referring to?

Would definitely be nice to have some indication of how far along the search is though!

Curious why this was removed?

@Scienfitz
Copy link
Collaborator

@brandon-holt this Issue is just about the documentation, where progress bars have been removed. The progress bars when using our simulation module should still be there

@brandon-holt
Copy link
Contributor

@Scienfitz In the Simulation section, the section for simulate_experiment contains a codeblock for simulate scenarios:
https://emdgroup.github.io/baybe/userguide/simulation.html

Also, the codeblocks used don't make certain aspects of usage clear. For example, for the campaign variable, do we need to define a searchspace, or will the searchspace be automatically generated from initial_data?

Or, if we use the DataFrame option for the lookup variable, is that not the same dataframe as for initial_data?

@Scienfitz
Copy link
Collaborator

@brandon-holt thanks for spotting that! technically your points are not visual but about a bug and content suggestions, so we should not discuss these in this thread.

Would you be open to make s small PR fixing the code snippet? The respective .md file is in docs/userguide/simulation.md . You could also propose text changes that make clearer what you seek.

As for the searchspace question: Nothing is inferred from initial_data, is there anything specific that gave you that impression?

@brandon-holt
Copy link
Contributor

@Scienfitz Just made the PR!

Also, disregard my question about searchspace/initial_data I understand now!

@AdrianSosic

This comment was marked as outdated.

@AdrianSosic

This comment was marked as duplicate.

@AdrianSosic

This comment was marked as duplicate.

@Scienfitz

This comment was marked as duplicate.

@Scienfitz

This comment was marked as duplicate.

@AdrianSosic

This comment was marked as duplicate.

@AVHopp
Copy link
Collaborator Author

AVHopp commented Sep 3, 2024

Since the question came up in #347 : Some of the errors mentioned here are fixed in #347 , some things I do not know how to fix (like changing the name of baybe in the TOC, I already tried that several times).
Regarding the other things here: Depending on the urgency, I can take care of these in an upcoming PR and then close this issue and we start another one once we accumulate more stuff. What is your opinion here?

AVHopp added a commit that referenced this issue Oct 15, 2024
This PR fixes the displayed math in the docstring of the CardinalityConstraint class (see #195 ).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants