Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test vite beta #2251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

patricklx
Copy link
Contributor

No description provided.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how we update dependencies in scenario-tester, you should take a look at https://github.com/embroider-build/embroider/pull/2239/files#diff-8b0532bf6fa0cedefd195e7fdffb75f04d70ddeaf3c08a733179465071295062 to get a feel how to add a new Vite version to the matrix

@patricklx
Copy link
Contributor Author

oh, I see, that PR is actually testing the beta now. not necessary 6, https://pkg.pr.new/vite@main points to beta.
might rename vite-6 to vite-beta
I see that it was not necessary to update lock file? so scenario tester will get the latest?

@mansona
Copy link
Member

mansona commented Feb 5, 2025

CI always runs in no-lockfile mode, so if you have a dependency correctly specified that it will float in that context then yes it will work 👍

When we get the other PR merged you should just add beta to the matrix and it will get tested along with 5.x and 6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants