Expose macros config in babel #2249
Open
+189
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@embroider/macros were not configurable in main/vite before this change.
Proposed way of configuring macros is similar to how we've been doing so in ember-cli-build.js
For example, in the babel config:
However, this doesn't solve the problem of configuring macros for the minimal app over in #2205
For the minimal app blueprint, we'd have folks do this in their babel config:
which.... could be better...
So.... I've done added to macros to allow for:
Which should be nice for the minimal blueprint in #2205