stop nullifying loader.js #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
NullVoxPopuli
approved these changes
Feb 1, 2025
void-mAlex
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2207
We agreed that we would stop nullifying loader.js even though we don't use it any more for anything. This is to stop us from preventing other people using it for custom things.
Note: this won't mean that there are any of ember's entities in requirejs.entries, it just means that if you have custom code that is using this system it's not blocked from working any more.
Note: I considered adding tests for this but that would suggest that we support loader.js and could imply that we recommend using it. This PR just stops preventing people from using it which I think is ok without a test? thoughts?