Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Vite 6 #2211

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Require Vite 6 #2211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"peerDependencies": {
"@embroider/core": "workspace:^",
"vite": "^5.2.0"
"vite": "^6.0.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we allow both versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an advantage to keeping v5 support?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

counter point: is there any need to drop support for 5 🤷 We should be expanding the range because we don't have any functionality that requires v6

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we have a feature planned that required the new environments stuff?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

},
"scripts": {
"test": "jest"
Expand Down Expand Up @@ -41,7 +41,7 @@
"@types/jsdom": "^16.2.11",
"@types/send": "^0.17.4",
"rollup": "^4.18.0",
"vite": "^5.3.3"
"vite": "^6.0.3"
},
"files": [
"index.mjs",
Expand Down
Loading
Loading