Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli 6.1, eslint 9, eslint flat config, RFC#1055 #320

Merged
merged 17 commits into from
Jan 15, 2025

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Jan 6, 2025

If anyone wishes to create new addons with 6.1 in the mean time:

git clone git@github.com:embroider-build/addon-blueprint.git
cd addon-blueprint
git checkout update-ember-cli
pnpm install
cd ../
npx ember-cli@latest addon my-addon-name --blueprint ./addon-blueprint --pnpm --typescript
cd my-addon-name
# delete all the ember-data stuff from package.json and tsconfig.json

We can't have multiple versions of eslint in a monorepo

Closes:

Related:

UPDATE! below was previously blocking stuff -- ember-data hasn't published types correctly, but this PR removes ember-data types from the tsconfig.json, so it's not blocking. See below links for work tracking addressing the underlying issues.


Tangents, potentially not-blocking

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jan 6, 2025
@NullVoxPopuli NullVoxPopuli changed the title ember-cli < 6.1 is too old, upgrade to ember-cli 6.1 ember-cli 6.1, eslint 9, eslint flat config, RFC#1055 Jan 6, 2025
@sukima
Copy link

sukima commented Jan 6, 2025

Will this PR allow addon authors to run this and have it just work out of the box? Is this incantation documented anywhere?

npx ember-cli@latest addon \
  my-addon \
  --blueprint @embroider/addon-blueprint \
  --pnpm \
  --typescript

@sukima
Copy link

sukima commented Jan 6, 2025

Is this related to #219 ?

@NullVoxPopuli
Copy link
Collaborator Author

Will this PR allow addon authors to run this and have it just work out of the box?

Correct. We're at a weird time right now, because ember-cli broke this blueprint in its 6.1 release.

Is this incantation documented anywhere?

This repo's readme

@NullVoxPopuli NullVoxPopuli requested a review from mansona January 14, 2025 21:57
@NullVoxPopuli NullVoxPopuli merged commit 8144fec into main Jan 15, 2025
13 checks passed
@NullVoxPopuli NullVoxPopuli deleted the update-ember-cli branch January 15, 2025 00:06
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants