-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-cli 6.1, eslint 9, eslint flat config, RFC#1055 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
ember-cli < 6.1 is too old, upgrade to ember-cli 6.1
ember-cli 6.1, eslint 9, eslint flat config, RFC#1055
Jan 6, 2025
Will this PR allow addon authors to run this and have it just work out of the box? Is this incantation documented anywhere? npx ember-cli@latest addon \
my-addon \
--blueprint @embroider/addon-blueprint \
--pnpm \
--typescript |
Is this related to #219 ? |
SergeAstapov
approved these changes
Jan 7, 2025
Correct. We're at a weird time right now, because ember-cli broke this blueprint in its 6.1 release.
This repo's readme |
This was referenced Jan 9, 2025
Closed
NullVoxPopuli
force-pushed
the
update-ember-cli
branch
from
January 14, 2025 18:11
990128d
to
6e0538e
Compare
NullVoxPopuli
force-pushed
the
update-ember-cli
branch
from
January 14, 2025 19:19
6e0538e
to
a8f608c
Compare
Closed
ef4
approved these changes
Jan 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If anyone wishes to create new addons with 6.1 in the mean time:
We can't have multiple versions of eslint in a monorepo
Closes:
Related:
UPDATE! below was previously blocking stuff -- ember-data hasn't published types correctly, but this PR removes ember-data types from the tsconfig.json, so it's not blocking. See below links for work tracking addressing the underlying issues.
new
:--ember-data
(default), and--no-ember-data
ember-cli/ember-cli#10613Tangents, potentially not-blocking