Update Ember to 3.28 #240
Update Ember to 3.28 #240
Conversation
lolmaus
force-pushed
the
update-ember
branch
2 times, most recently
from
2b3fa53
to
2bf7ae5
Compare
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
@kategengler This is ready for review! 🙏 |
app/components/page-layout.hbs
Outdated
| {{#if addonName.isFullSearchLink}} | ||
| <LinkTo @route="index" @query={{hash query=options.searchText}} class="jump-to-full-search test-search-result-jump-to-full-search-link"> | ||
| <span class="jump-to-full-search test-search-result test-search-result-jump-to-full-search-link"> |
There was a problem hiding this comment.
You've lost behavior here, however -- you can no longer right click -> open in new tab from the results in the typeahead.
There was a problem hiding this comment.
@kategengler I have reverted that commit and found no other solution to it. The problem is very weird:
When an <a> inside a PowerSelect's <li> is clicked, a hard redirect happens. The action attached to the <a> never fires.
The event target is <a>, while the event handler is attached to the <li>.
My guess is that it's the browser that's causing a hard redirect as it processes the click on <a>. But event.preventDefault() and event.stopPropagation() don't prevent this. :(
It only happens programmatically. I. e. when I replace click() with pauseTest(), click by hand and resume, the test passes.
I worked around the issue by replacing click(find('a')) with click(find('a').parentElement). This is not a good solution as it's not what the user is actually doing. But it happens to resolve the issue, and the issue only happens in test.
If you have any other ideas to fix this, please tell me. One possibility is to upgrade Ember further, maybe it's a regression that has been fixed.
CC @mansona
…ide a PowserSelect's <li>
Updated via
pnpx ember-cli-update --to 3.28, followed by a few manual fixes.