Remove --disable-gpu flag when starting headless chrome #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--disable-gpu` flag is [no longer necessary](https://bugs.chromium.org/p/chromium/issues/detail?id=737678) and, at least in some cases, is [causing issues](https://bugs.chromium.org/p/chromium/issues/detail?id=982977). This flag has already been [removed from ember-cli's blueprints](ember-cli/ember-cli#8774) As you may already know, this project's test suite is run as part of [Ember Data](https://github.com/emberjs/data)'s test suite to help catch regressions. The flag has already been [removed from Ember Data's own testem config](emberjs/data#6298) but Ember Data's complete test suite cannot successfully run until all of our external integration partners have also removed this flag.
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 106 106
Lines 818 818
=======================================
Hits 644 644
Misses 174 174Continue to review full report at Codecov.
|
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--disable-gpuflag is no longer necessary and, at least in some cases, is causing issues.This flag has already been removed from ember-cli's blueprints
As you may already know, this project's test suite is run as part of Ember Data's test suite to help catch regressions. The flag has already been removed from Ember Data's own testem config but Ember Data's complete test suite cannot successfully run until all of our external integration partners have also removed this flag.