Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Adds ember survey call to action #3851

Merged
merged 8 commits into from
Mar 7, 2019
Merged

Adds ember survey call to action #3851

merged 8 commits into from
Mar 7, 2019

Conversation

MinThaMie
Copy link
Contributor

What it does

My first blog post :)

Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this reads great! ✨ Do you have the time to add your name to the contributor list

  • at the top list, right before crowd
  • at the bottom of the post, right before the word crowd

Otherwise this is already good to go from my side! Feel free to apply any suggestions from the review by using the Apply suggestion feature here on Github 🐹

source/blog/2019-03-08-the-ember-times-issue-88.md Outdated Show resolved Hide resolved
source/blog/2019-03-08-the-ember-times-issue-88.md Outdated Show resolved Hide resolved
@MinThaMie
Copy link
Contributor Author

Done :)

Co-Authored-By: MinThaMie <anne-greeth.vanherwijnen@nedap.com>
Co-Authored-By: MinThaMie <anne-greeth.vanherwijnen@nedap.com>
@amyrlam
Copy link
Member

amyrlam commented Mar 7, 2019

This is 💯, just add a short blurb where it says <SOME-INTRO-HERE-TO-KEEP-THEM-SUBSCRIBERS-READING> then good to merge

Thanks for putting up with all of our edits!

We have some "orientation" to contributing here, it's a living document

Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 welcome to the times!

@MinThaMie
Copy link
Contributor Author

Added something, however I'm open for better suggestions. I wanted to include something about the deadline, but then it would become a long intro :D

Copy link
Member

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads awesome, thank you for this great writeup for the Ember Times! 🐹 ✨

@jayjayjpg jayjayjpg merged commit 6c33e26 into emberjs:blog/embertimes-88 Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants