Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

DEPRECATION: Ember.MODEL_FACTORY_INJECTIONS #2895

Merged
merged 2 commits into from
May 17, 2017
Merged

DEPRECATION: Ember.MODEL_FACTORY_INJECTIONS #2895

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94d884c
DEPRECATION: Ember.MODEL_FACTORY_INJECTIONS
stefanpenner May 5, 2017
d301aae
Update v2.x.html.md
locks May 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions source/deprecations/v2.x.html.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,3 +986,20 @@ export default Ember.Service.extend({
}
});
```

#### Ember.MODEL_FACTORY_INJECTIONS removed

##### until: 2.17.0
##### id: ember-metal.model_factory_injections

The flag `Ember.MODEL_FACTORY_INJECTIONS` is no longer required, and can be
safely removed from your ember >= 2.13 application.

This flag was [added in 2013](https://github.com/emberjs/ember.js/commit/ffd9314620005c16e6cc05589a9e8b7ffc1da090) for Ember Data compatibility with the Dependency Injection (DI) system.
At the time, Ember's DI blurred the idea of a factory and a class which caused several issues,
including one that resulted in this flag being required.

Since then, both Ember and Ember Data have addressed the various issues which lead to this flag.
Most recently, Ember's DI system introduced the `factoryFor` API which separates factores and classes.
With this step, the flag in question no longer has any affect, and can be safely removed.