This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Adding deprecation information for the rename of Ember.Router.router #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o EmberRouter.routerMicrolib
rwjblue
reviewed
Feb 9, 2017
source/deprecations/v2.x.html.md
Outdated
| ##### until: 2.16.0 | ||
| ##### id: ember-router.router | ||
|
|
||
| The `router` property of `EmberRouter` has been renamed to `routerMicrolib` to disambiguate it from `router.js`, the microlib used within `EmberRouter`. |
There was a problem hiding this comment.
Can you slightly rephrase to:
The private
routerproperty of theEmber.Routerinstance (commonly found asthis.routerin Ember.Route instances or viarouter:mainin the container) has been renamed......
source/deprecations/v2.x.html.md
Outdated
|
|
||
| The `router` property of `EmberRouter` has been renamed to `routerMicrolib` to disambiguate it from `router.js`, the microlib used within `EmberRouter`. | ||
|
|
||
| Addon and application developers that are using the internal `router` property of `EmberRouter` should replace those usages with `EmberRouter.routerMicrolib`. |
There was a problem hiding this comment.
Lets use Ember.Router instead of EmberRouter throughout...
source/deprecations/v2.x.html.md
Outdated
|
|
||
| Addon and application developers that are using the internal `router` property of `EmberRouter` should replace those usages with `EmberRouter.routerMicrolib`. | ||
|
|
||
| This example demonstrates a common use case for `EmberRouter.router`. |
There was a problem hiding this comment.
Lets just say .router here (e.g. not EmberRouter.router, but just "the .router property).
source/deprecations/v2.x.html.md
Outdated
|
|
||
| Before: | ||
|
|
||
| ``` javascript |
source/deprecations/v2.x.html.md
Outdated
| Before: | ||
|
|
||
| ``` javascript | ||
| Ember.Service.extend({ |
There was a problem hiding this comment.
lets say export default Ember.Service.extend({
source/deprecations/v2.x.html.md
Outdated
|
|
||
| After: | ||
|
|
||
| ``` javascript |
source/deprecations/v2.x.html.md
Outdated
| After: | ||
|
|
||
| ``` javascript | ||
| Ember.Service.extend({ |
There was a problem hiding this comment.
export default Ember.Service.extend({
scalvert
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information related to the rename of
EmberRouter.routertoEmberRouter.routerMicroliband the associated deprecation.Related PRs:
emberjs/ember.js#14919
Reviewers
@rwjblue @locks
Changes: