Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Deprecate Ember.assign #750

Merged
merged 5 commits into from
Jul 9, 2021
Merged

RFC: Deprecate Ember.assign #750

merged 5 commits into from
Jul 9, 2021

Conversation

nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented May 26, 2021 •
edited
Loading

rwjblue
rwjblue reviewed May 26, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

text/0000-deprecate-ember-assign.md Outdated Show resolved Hide resolved
text/0000-deprecate-ember-assign.md Outdated Show resolved Hide resolved
text/0000-deprecate-ember-assign.md Outdated Show resolved Hide resolved
nlfurniss and others added 3 commits May 26, 2021 13:57
@nlfurniss @rwjblue
Update text/0000-deprecate-ember-assign.md
65d2284 
Co-authored-by: Robert Jackson <me@rwjblue.com>
@nlfurniss @rwjblue
Update text/0000-deprecate-ember-assign.md
f76e1f7 
Co-authored-by: Robert Jackson <me@rwjblue.com>
@nlfurniss
Correct filename
f623f9d
@nlfurniss nlfurniss requested a review from rwjblue May 26, 2021 22:28
@chancancode
Copy link
Member

chancancode commented Jun 25, 2021 •
edited
Loading

This was discussed at today's framework team meeting and we think this is ready for Final Comment Period! The header still need to be updated for this to be merged, assuming it completes the FCP.

@chancancode chancancode merged commit 58535b6 into emberjs:master Jul 9, 2021
@nlfurniss nlfurniss deleted the deprecate-ember-assign branch July 13, 2021 17:19
This was referenced Jul 15, 2021
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancancode chancancode chancancode left review comments

@chriskrycho chriskrycho chriskrycho left review comments

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
Final Comment Period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nlfurniss @chancancode @rwjblue @chriskrycho