-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracked Properties Updates #478
Conversation
I understand what's happening here but my issue with the fix is it seems like it requires you to put the |
We tend to do deprecations as separate RFCs from introducing new features. Computed properties aren't officially deprecated yet, though they likely will be sometime in the future. Until then, I don't think we should provide a deprecation warning for users of A linting rule may make more sense here. There is precedent with the "avoid-observers" eslint rules, for instance. I don't believe we need an RFC to create a rule like that though. |
Agree, we can create the rule without any RFC type things. We'd only need to RFC enabling it by default. |
Since this is important to the interop story, we've decided to move this into FCP. |
Basically a |
If we made |
However, there still are two cases where you _will_ need to use them: | ||
|
||
- When accessing and updating plain, undecorated properties on objects | ||
- When using Ember's `ObjectProxy` class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a third case: manual proxies that implement unknownProperty
and setUnknownProperty
As we've discussed a |
This was introduced in [emberjs/rfcs#478](https://github.com/emberjs/rfcs/blob/master/text/0478-tracked-properties-updates.md#depending-on-native-getters) and is available in Ember 3.13.0-beta.1 and higher.
This was introduced in [emberjs/rfcs#478](https://github.com/emberjs/rfcs/blob/master/text/0478-tracked-properties-updates.md#depending-on-native-getters) and is available in Ember 3.13.0-beta.1 and higher.
Rendered