Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "final comment period" into process description #149

Merged
merged 1 commit into from
Jun 29, 2016

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Jun 23, 2016

This PR introduces the concept of a "final comment period" into the RFC process. This period is intended to focus the community's attention for a final round of consideration and feedback before an RFC is merged.

This concept was proposed and agreed upon by the core team at the June F2F meeting.

[Ember's official Twitter account](https://twitter.com/emberjs) will post a
tweet about the RFC to attract the community's attention.
* At the close of the final comment period, the [core team] will decide whether
to accept the RFC by merging the pull request and assigning the RFC a number,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the number is the PR #

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need to mention the concept of a number here at all? (I just copied this part from the old verbiage)

@dgeb dgeb force-pushed the final-comment-period branch 3 times, most recently from 6a8ae89 to c57c22c Compare June 24, 2016 13:15
@dgeb
Copy link
Member Author

dgeb commented Jun 24, 2016

@wycats r?

* Eventually, somebody on the [core team] will either accept the RFC by
merging the pull request and assigning the RFC a number, at which point
the RFC is 'active', or reject it by closing the pull request.
* Eventually, the [core team] will decide whether the RFC is a candidate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgeb I thought this was supposed to be the subteam that puts an RFC into FCP, then the core team have seven days to respond. The intent is that the subteams can iterate on RFCs and FCP is when core should look up and be aware of what is happening.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed at the core team meeting that the details of how subteams work hasn't yet been through the RFC process, and therefore we can't yet make them a formal part of the process. That's coming soon, though.

@mixonic
Copy link
Member

mixonic commented Jun 27, 2016

one more note, I think the rest looks good

* Eventually, the [core team] will decide whether the RFC is a candidate
for inclusion in Ember.
* RFCs that are candidates for inclusion in Ember will enter a "final comment
period", which shall be no shorter than 7 days. This period will be signaled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be seven days; making it variable makes it harder for people to follow along.

@dgeb dgeb force-pushed the final-comment-period branch from c57c22c to 5d357a3 Compare June 28, 2016 21:05
@dgeb
Copy link
Member Author

dgeb commented Jun 28, 2016

@mixonic @wycats Thanks for the review.

I've updated to specify the length of the final comment period as 7 days (instead of >= 7 days) and included verbiage about rejection requiring public discussion and a comment explaining the rationale for rejection.

@mixonic
Copy link
Member

mixonic commented Jun 29, 2016

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants