Skip to content

Commit

Permalink
Merge pull request #194 from GavinJoyce/gj/deprecate-custom-event-man…
Browse files Browse the repository at this point in the history
…anger

Deprecate component `eventManager`
  • Loading branch information
mixonic authored Mar 26, 2017
2 parents 8f302c7 + c0106e2 commit 95a78b9
Showing 1 changed file with 38 additions and 0 deletions.
38 changes: 38 additions & 0 deletions text/0000-deprecate-custom-event-manager.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
- Start Date: (fill me in with today's date, YYYY-MM-DD)
- RFC PR: (leave this empty)
- Ember Issue: (leave this empty)

# Summary

Support for component `eventManger`s is a seldom used feature and should
be deprecated.

# Motivation

We should strive to simplify the Ember API and source code where possible. As
the custom `eventManager` feature is rarely used in apps, we should deprecate
it.

# Detailed design

We'll introduce a deprecation warning which will be displayed when a component
defines an `eventManager` property or when `canDispatchToEventManager` is set to
true on `EventDispatcher`. The warning will have a target version of `3.0`.

If required, we can create an addon which extends the `EventDispatcher` allowing
for opt-in custom `eventManager`s in Ember apps.

# How We Teach This

As this is a seldom used feature, we can simply note the deprecation in a
future release blog post.

# Drawbacks

This adds a little more churn for apps that rely on this feature.

# Alternatives

This feature was [recently made pay-as-you-go](https://github.com/emberjs/ember.js/pull/14756),
so the immediate performance concerns have been addressed. We could decide to
leave this in the framework as an opt-in feature.

0 comments on commit 95a78b9

Please sign in to comment.