add v2 addon metadata #20744
Merged
add v2 addon metadata #20744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds v2-addon-style metadata to the package.json at publication. Our build already produces everything needed to be a valid v2 addon, other than this metadata. This PR doesn't actually flip the final switch though (by adding `version: 2` to the metdata). So it's safe and nonbreaking. This just gets us one step closer. And it's helpful because embroider users will be able to opt in to treating ember-source as v2 even before we force it to be v2 for everyone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds v2-addon-style metadata to the package.json at publication. Our build already produces everything needed to be a valid v2 addon, other than this metadata.
This PR doesn't actually flip the final switch though (by adding
version: 2to the metdata). So it's safe and nonbreaking. This just gets us one step closer.And it's helpful because embroider users will be able to opt in to treating ember-source as v2 even before we force it to be v2 for everyone.