Removed circular dependencies #20734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might also want #20723 for this:) it just enables eslint cycle import check. The plugin for it was already installed |
|
Yea, good idea, we should prevent new cycles from creeping in. There is a spot in the rollup config where we could just fail the whole build if rollup sees a cycle. |
|
Did a review with @kategengler and I have a few more minor changes and then this is good to go. |
|
I investigated the one proposed minor change, which was whether we should better hide these newly created modules from outside consumers, but that would not be consistent with how these packages are already published. Only a few (like |
ef4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.