Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Cleanup #20682

Merged
merged 1 commit into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,6 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup
- name: build
env:
DISABLE_SOURCE_MAPS: true
BROCCOLI_ENV: production
run: pnpm ember build
- name: Upload build
uses: actions/upload-artifact@v3
Expand All @@ -87,9 +84,6 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup
- name: build
env:
DISABLE_SOURCE_MAPS: true
BROCCOLI_ENV: production
run: pnpm ember build
- name: Upload build
uses: actions/upload-artifact@v3
Expand All @@ -110,9 +104,6 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup
- name: build
env:
DISABLE_SOURCE_MAPS: true
BROCCOLI_ENV: production
run: pnpm ember build
- name: Upload build
uses: actions/upload-artifact@v3
Expand All @@ -134,8 +125,6 @@ jobs:
- uses: ./.github/actions/setup
- name: build
env:
DISABLE_SOURCE_MAPS: true
BROCCOLI_ENV: production
SHOULD_TRANSPILE: true
run: pnpm ember build

Expand Down Expand Up @@ -178,28 +167,10 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup
- name: build
env:
DISABLE_SOURCE_MAPS: true
BROCCOLI_ENV: production
run: pnpm ember build -prod
- name: test
run: pnpm test

production-debug-render-test:
name: Production (All Tests + Canary Features with Debug Render Tree)
runs-on: ubuntu-latest
needs: [basic-test, lint, types]
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup
- name: build
env:
DISABLE_SOURCE_MAPS: true
BROCCOLI_ENV: production
DEBUG_RENDER_TREE: true
run: pnpm ember build -prod
- name: test
run: pnpm test

extend-prototypes-test:
name: Extend Prototypes
Expand All @@ -226,8 +197,6 @@ jobs:
- uses: ./.github/actions/setup
- name: build
env:
DISABLE_SOURCE_MAPS: true
BROCCOLI_ENV: production
SHOULD_TRANSPILE_FOR_NODE: true
run: pnpm ember build -prod
- name: test
Expand Down Expand Up @@ -271,7 +240,6 @@ jobs:
lint,
browserstack-test,
production-test,
production-debug-render-test,
extend-prototypes-test,
node-test,
blueprint-test,
Expand All @@ -297,7 +265,6 @@ jobs:
lint,
browserstack-test,
production-test,
production-debug-render-test,
extend-prototypes-test,
node-test,
blueprint-test,
Expand Down Expand Up @@ -326,7 +293,6 @@ jobs:
lint,
browserstack-test,
production-test,
production-debug-render-test,
extend-prototypes-test,
node-test,
blueprint-test,
Expand Down Expand Up @@ -357,7 +323,6 @@ jobs:
lint,
browserstack-test,
production-test,
production-debug-render-test,
extend-prototypes-test,
node-test,
blueprint-test,
Expand Down
6 changes: 0 additions & 6 deletions bin/run-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ function getBrowserRunner() {
}

function run(queryString) {
if (process.env.DEBUG_RENDER_TREE) {
queryString = `${queryString}&debugrendertree`;
}

if (process.env.ALL_DEPRECATIONS_ENABLED) {
queryString = `${queryString}&alldeprecationsenabled=${process.env.ALL_DEPRECATIONS_ENABLED}`;
}
Expand Down Expand Up @@ -66,7 +62,6 @@ function generateTestsFor(packageName) {
}

testFunctions.push(() => run('package=' + packageName));
testFunctions.push(() => run('package=' + packageName + '&edition=classic'));
testFunctions.push(() => run('package=' + packageName + '&prebuilt=true'));
testFunctions.push(() => run('package=' + packageName + '&enableoptionalfeatures=true'));
}
Expand All @@ -87,7 +82,6 @@ function generateEachPackageTests() {

function generateStandardTests() {
testFunctions.push(() => run(''));
testFunctions.push(() => run('edition=classic'));
testFunctions.push(() => run('enableoptionalfeatures=true'));
}

Expand Down
12 changes: 2 additions & 10 deletions tests/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,8 @@
(function() {
window.EmberENV = window.EmberENV || {};

// Determine edition, and apply correct EmberENV settings
var edition = QUnit.urlParams.edition || 'octane';

if (edition === 'octane') {
EmberENV._DEFAULT_ASYNC_OBSERVERS = true;
}
// Test under octane defaults
EmberENV._DEFAULT_ASYNC_OBSERVERS = true;

// Test for "hooks in EmberENV.EMBER_LOAD_HOOKS['hookName'] get executed"
EmberENV.EMBER_LOAD_HOOKS = EmberENV.EMBER_LOAD_HOOKS || {};
Expand All @@ -49,10 +45,6 @@

EmberENV['RAISE_ON_DEPRECATION'] = true;

if (QUnit.urlParams.debugrendertree) {
EmberENV['_DEBUG_RENDER_TREE'] = true;
}

if (QUnit.urlParams.alldeprecationsenabled) {
EmberENV['_ALL_DEPRECATIONS_ENABLED'] = QUnit.urlParams.alldeprecationsenabled;
}
Expand Down
Loading