[BUGFIX beta] fix for TS 5.1 nightly narrowing change #20441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type here was `any` and *sort of* narrowing before; now it checks explicitly whether it is `string`. TS 5.1 seems to have a change (maybe a regression?) in how it narrows between the two branches, but previous versions simply fell back to `any` anyway rather than narrowing to the inferred types. This unblocks us for TS 5.1, but we should also rewrite this function handler entirely: if it were just two functions instead of using variadic function args, it would dramatically simplify *all* of this implementation (and almost certainly perform better, too!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type here was
anyand sort of narrowing before; now it checks explicitly whether it isstring. TS 5.1 seems to have a change (maybe a regression?) in how it narrows between the two branches, but previous versions simply fell back toanyanyway rather than narrowing to the inferred types. This unblocks us for TS 5.1, but we should also rewrite this function handler entirely: if it were just two functions instead of using variadic function args, it would dramatically simplify all of this implementation (and almost certainly perform better, too!).