Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Fix HistoryLocation preview types #20434

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Apr 8, 2023

These methods are optional in interface Location, but they are definitely present in class HistoryLocation.

These methods are optional in `interface Location`, but they are definitely present in `class HistoryLocation`.
@chriskrycho chriskrycho changed the title Fix HistoryLocation preview types [BUGFIX stable] Fix HistoryLocation preview types Apr 13, 2023
@chriskrycho
Copy link
Contributor

Excellent. I’ll merge and we can backport to 4.12!

@chriskrycho chriskrycho merged commit f905915 into main Apr 13, 2023
@chriskrycho chriskrycho deleted the fix-history-location-types branch April 13, 2023 01:42
@chriskrycho chriskrycho changed the title [BUGFIX stable] Fix HistoryLocation preview types [BUGFIX release] Fix HistoryLocation preview types Apr 13, 2023
@chriskrycho chriskrycho added Bug TypeScript Work on Ember’s types labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants