[RFC-774] Deprecate implicit record loading in Ember Route #20376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
wagenet
force-pushed
the
deprecate-implicit-loading-route
branch
2 times, most recently
from
eabe4e3
to
7966627
Compare
wagenet
force-pushed
the
deprecate-implicit-loading-route
branch
from
7966627
to
872ca37
Compare
wagenet
commented
Mar 10, 2023
wagenet
commented
Mar 10, 2023
wagenet
commented
Mar 10, 2023
wagenet
force-pushed
the
deprecate-implicit-loading-route
branch
from
872ca37
to
117a4c5
Compare
wagenet
force-pushed
the
deprecate-implicit-loading-route
branch
from
da96284
to
c00b33f
Compare
wagenet
force-pushed
the
deprecate-implicit-loading-route
branch
from
c00b33f
to
464fe3e
Compare
kategengler
reviewed
Aug 7, 2023
| `Please define an explicit model hook for ${this.fullRouteName}.`, | ||
| false, | ||
| { | ||
| id: 'deprecate-implicit-route-model', |
There was a problem hiding this comment.
I see there is a deprecation guide -- I think that should be here in the url property?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC-774
Deprecation App: ember-learn/deprecation-app#1334