Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Type export experimentation #20003

Closed
wants to merge 9 commits into from
Closed

[WIP] Type export experimentation #20003

wants to merge 9 commits into from

Conversation

wagenet
Copy link
Member

@wagenet wagenet commented Mar 3, 2022 •
edited
Loading

Includes #20090

@wagenet wagenet force-pushed the typings-export branch 2 times, most recently from 56dc9a7 to 49d5ad0 Compare March 8, 2022 14:43
chriskrycho
chriskrycho requested changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits from the modules affected, will deeply-read-and-understand build-docs.js next.

packages/@ember/-internals/glimmer/lib/component-managers/curly.ts Outdated Show resolved Hide resolved
packages/@ember/-internals/runtime/lib/system/core_object.d.ts Outdated Show resolved Hide resolved
@wagenet wagenet force-pushed the typings-export branch 3 times, most recently from 46de6a4 to cc3f254 Compare May 13, 2022 17:25
@locks
Copy link
Contributor

locks commented Aug 4, 2023

I see a lot of conflicts. Has the work been done elsewhere?

@kategengler
Copy link
Member

Is this still relevant? It is a draft PR

@chriskrycho
Copy link
Contributor

I believe this was superceded in its entirety by #20449 (as well as the foundational PRs which preceded it); this was Peter's admirable first pass at trying to get types publishing, and was invaluable prior art in informing the Ember TypeScript team that we were going to have to do the absolute shenanigans that we did in #20449 to get things published. Closing accordingly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wagenet @locks @kategengler @chriskrycho