[router.ts] Convert this._super to super #19683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The router class has already been converted to a native JS class, so it should be using `super.willDestroy` in its `willDestroy` hook instead of `this._super`.
elwayman02
commented
Jul 29, 2021
| @@ -802,7 +802,7 @@ class EmberRouter extends EmberObject.extend(Evented) implements Evented { | |||
| this._toplevelView = null; | |||
| } | |||
|
|
|||
| this._super(...arguments); | |||
| super.willDestroy(); | |||
There was a problem hiding this comment.
Per errors from tslint, we need to drop ...arguments here because the underlying base method for willDestroy is already known to accept 0 arguments.
rwjblue
approved these changes
Jul 30, 2021
jgwhite
added a commit
to hashicorp/waypoint
that referenced
this pull request
Sep 24, 2021
Includes the following bugfixes: - [#19685](emberjs/ember.js#19685) Fix memory leak with `RouterService` under Chrome - [#19683](emberjs/ember.js#19683) Ensure `super.willDestroy` is called correctly in `Router`'s `willDestroy`
jgwhite
added a commit
to hashicorp/waypoint
that referenced
this pull request
Sep 24, 2021
Includes the following bugfixes: - [#19685](emberjs/ember.js#19685) Fix memory leak with `RouterService` under Chrome - [#19683](emberjs/ember.js#19683) Ensure `super.willDestroy` is called correctly in `Router`'s `willDestroy`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The router class has already been converted to a native JS class, so it should be using
super.willDestroyin itswillDestroyhook instead ofthis._super.