Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove computed deep each #19673

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Remove computed deep each #19673

merged 1 commit into from
Jul 31, 2021

Conversation

nlfurniss
Copy link
Contributor

@nlfurniss nlfurniss commented Jul 22, 2021

Part of #19662
ember-metal.computed-deep-each
Tests pass locally

The code in getChainTags was deleted because it seems that that condition won't be reached since setting a deep dependent key will throw an error before it can be geted.

@mixonic mixonic mentioned this pull request Jul 23, 2021
58 tasks
Copy link
Sponsor Member

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pzuraq This could use your eyes. I'm not sure which site should be changed to raise the error, and if the error should be a hard throw or simply a dev-only assert. As this code is performance sensitive, dev-only seems fine by my own intuition, but I'd like more feedback.

@pzuraq
Copy link
Contributor

pzuraq commented Jul 26, 2021

This should be a dev-only assert, definitely. I believe the location of the new error is correct though, it should catch both cases and properly prevent them (since the each case is a special case of the nested chaining case)

@nlfurniss
Copy link
Contributor Author

This should be a dev-only assert, definitely. I believe the location of the new error is correct though, it should catch both cases and properly prevent them (since the each case is a special case of the nested chaining case)

Sounds good, updated

@nlfurniss nlfurniss requested a review from mixonic July 29, 2021 14:47
@mixonic
Copy link
Sponsor Member

mixonic commented Jul 31, 2021

This looks great to me, I pushed a rebase of the branch to address a conflict and will merge.

@mixonic mixonic merged commit 88c67f1 into emberjs:master Jul 31, 2021
@nlfurniss nlfurniss deleted the remove-computed-deep-each branch July 31, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants