Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE modernized-built-in-components] Remaining implementation work #19382

Merged
merged 11 commits into from
Feb 26, 2021

Conversation

chancancode
Copy link
Member

@chancancode chancancode commented Feb 5, 2021

Instead of hard-coding a list of events to bind (copied from the EventDispatcher – which could be reopened and modified), this refactor uses a modifier to dynamically read the list from the EventDispatcher at runtime instead.

Also switches the <Textarea /> component to use the new implementation. Passes all existing tests.

Part of #19270

@chancancode chancancode changed the title Get events map from EventDispatcher [FEATURE modernized-built-in-components] Get events map from EventDispatcher Feb 5, 2021
@chancancode chancancode changed the title [FEATURE modernized-built-in-components] Get events map from EventDispatcher [FEATURE modernized-built-in-components] Get events map from EventDispatcher & Modernize <Textarea> Feb 5, 2021
@chancancode chancancode force-pushed the refactor-input-component branch 3 times, most recently from 3d14467 to 31c9392 Compare February 6, 2021 03:47
@chancancode chancancode force-pushed the refactor-input-component branch 4 times, most recently from 3d74fde to c79bf85 Compare February 9, 2021 03:08
@chancancode chancancode force-pushed the refactor-input-component branch 5 times, most recently from 10c9a89 to 4bb3713 Compare February 13, 2021 22:34
chancancode and others added 10 commits February 25, 2021 03:01
Instead of hard-coding a list of events to bind (copied from the
`EventDispatcher` – which could be reopened and modified), this
refactor uses a modifier to dynamically read the list from the
`EventDispatcher` at runtime instead.

Part of #19270
Switches the <Textarea /> component to use the new implementation
as well. Passes all existing tests.

Part of #19270
Deprecate all unsupported args (and "deopt" the component for now)
according to RFC 707.

Part of #19270
…trings

Tracking issue: #19270
Get tests passing for no actions passed to inputs as strings deprecation
…nt handlers

Tracking issue: #19270
Enables the input and textarea  event handlers deprecation introduced in #19218
and fixes resultant failing tests
Refactor to extra shared code into internal component to pave way
for implementing <LinkTo> with the new infrastructure.

Part of #19270
@chancancode chancancode changed the title [FEATURE modernized-built-in-components] Get events map from EventDispatcher & Modernize <Textarea> [FEATURE modernized-built-in-components] Remaining implementation work Feb 25, 2021
@rwjblue rwjblue merged commit 4cb7da4 into master Feb 26, 2021
@rwjblue rwjblue deleted the refactor-input-component branch February 26, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants