[BUGFIX release] Ensure query param only <LinkTo /> are properly scoped in engines. #19337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in engines.
Prior to this change, the test would fail with the following:
```
Assertion Failed: You attempted to generate a link for the "UNDEFINED" route, but did not pass the models required for generating its dynamic segments. There is no route named blog.blog.category
at assert (http://localhost:7020/tests/ember.js:32996:15)
at Class.computeLinkToComponentHref (http://localhost:7020/tests/ember.js:5808:50)
at http://localhost:7020/tests/ember.js:11860:25
at untrack (http://localhost:7020/tests/ember.js:54650:14)
at ComputedProperty.get (http://localhost:7020/tests/ember.js:11859:32)
at Class.getter [as href] (http://localhost:7020/tests/ember.js:10949:25)
at getPossibleMandatoryProxyValue (http://localhost:7020/tests/ember.js:11250:19)
at _getProp (http://localhost:7020/tests/ember.js:11315:17)
at http://localhost:7020/tests/ember.js:45192:45
at http://localhost:7020/tests/ember.js:45140:37
```
This is because inside a QP only transition we always use
`_currentRoute` which has **already been namespaced**.
|
/cc @chancancode |
chancancode
approved these changes
Jan 14, 2021
rwjblue
deleted the
ensure-query-param-only-transitions-work-in-engines
branch
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the test would fail with the following:
This is because inside a QP only transition we always use
_currentRoutewhich has already been namespaced.Introduced in #19223 (and released in 3.24.0).