[FEATURE strict-mode] Update VM for Strict Mode #19302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
feat/update-glimmer-vm-for-strict-mode
branch
2 times, most recently
from
db8abb2
to
9886499
Compare
rwjblue
reviewed
Dec 10, 2020
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
Show resolved
Hide resolved
pzuraq
force-pushed
the
feat/update-glimmer-vm-for-strict-mode
branch
from
9886499
to
8180b67
Compare
rwjblue
approved these changes
Dec 10, 2020
pzuraq
force-pushed
the
feat/update-glimmer-vm-for-strict-mode
branch
2 times, most recently
from
d86a727
to
ac20b89
Compare
Updates the Glimmer VM to the latest version, which includes strict mode. Strict mode is currently guarded behind a canary flag, but for the most part only involves changes to the VM. The biggest changes are to the template compiler's `compile` function, which has to change in order to still be functional as scope values must be provided in some way, and the resolver, which needs to provide keyword built-ins now in strict templates. Release notes for the VM: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.69.0
pzuraq
force-pushed
the
feat/update-glimmer-vm-for-strict-mode
branch
from
ac20b89
to
998243e
Compare
rwjblue
approved these changes
Dec 11, 2020
| export const InputComponent = { | ||
| // Factory interface | ||
| create(): never { | ||
| throw assert('Use constructor instead of create'); |
There was a problem hiding this comment.
Throw assert seems odd? (Non blocking as it was already like this)
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Glimmer VM to the latest version, which includes strict
mode. Strict mode is currently guarded behind a canary flag, but for the
most part only involves changes to the VM. The biggest changes are to
the template compiler's
compilefunction, which has to change in orderto still be functional as scope values must be provided in some way, and
the resolver, which needs to provide keyword built-ins now in strict
templates.
Release notes for the VM: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.69.0