[BUGFIX beta] Restores the shadowed property set behavior #19232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restores the previous behavior that would happen when setting a shadowed property.
pzuraq
changed the title
rwjblue
approved these changes
Oct 26, 2020
|
@andreyfel it will not be backported to 3.21, per our support policy 3.21 is no longer supported. It is fixed on 3.22, and will be fixed on 3.23+ via this PR. |
|
@pzuraq I think it is not fixed on 3.22. Or do you mean it is fixed but not released yet? |
|
Right. We still need to release. It's been on my plate for a few days but I've been super swamped at work. Will try to get it done this weekend. |
|
Sure, no problem! Thanks @rwjblue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the previous behavior that would happen when setting a shadowed
property.
Based on #19231 it appears that our previous fix isn't enough, and the implications
of the change were wider spread than we initially believed. So, this restores the
previous behavior. The plan is to add a lint rule to prevent unintentional shadowing
from causing issues, e.g.
model: Foo;should instead bedeclare model: Foo;.