[BUGFIX lts] dont access properties during init unless required #19023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
approved these changes
Jun 20, 2020
|
After further investigation this issue began in the 3.15 release and was not present prior, so backporting to 3.16 will allow EmberData to use this pattern back to 3.12 :) |
|
Thanks for tracking this down! |
|
@runspired / @snewcomer - This is included in ember-source@3.20.0-beta.3, mind testing to confirm that this fixes that issue in Ember Data? |
|
@rwjblue I tested this locally before submitting, but I'll run a quick test to double ensure :) |
|
Ah, gotcha, thank you! I mostly just want a little bit of sanity check before releasing the patch release of 3.19 (and then more sanity check of that patch release before backporting to 3.16). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were greedily accessing properties during init in all cases if a value for the property was passed into create. In the case of native getters/setters this could lead to rendering invalidations if initialization was triggered during render since the value would immediately change after access.
This possibly supplants #19009 and may fix if so #19003 but more investigation should be done to confirm that.