[BUGFIX] Suspend observer deactivation during property changes #18774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Feb 27, 2020
| @@ -1,6 +1,6 @@ | |||
| import { Meta, peekMeta } from '@ember/-internals/meta'; | |||
| import { symbol } from '@ember/-internals/utils'; | |||
| import { flushSyncObservers } from './observer'; | |||
| import { flushSyncObservers, resumeObserverDeactivation, suspendedObserverDeactivation } from './observer'; | |||
There was a problem hiding this comment.
$ eslint . --cache --ext=js,ts
/home/travis/build/emberjs/ember.js/packages/@ember/-internals/metal/lib/property_events.ts
3:9 error Replace `·flushSyncObservers,·resumeObserverDeactivation,·suspendedObserverDeactivation·` with `⏎··flushSyncObservers,⏎··resumeObserverDeactivation,⏎··suspendedObserverDeactivation,⏎` prettier/prettier
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
krisselden
approved these changes
Feb 27, 2020
We accidentally removed some tests for timing changes in observers when we were originally refactoring observers. This PR adds these tests back, and suspends deactivation of observers until after property changes have completed and observers have been properly fired.
pzuraq
force-pushed
the
bugfix/fix-property-changes
branch
from
31f49e9
to
9c373be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally removed some tests for timing changes in observers when
we were originally refactoring observers. This PR adds these tests back,
and suspends deactivation of observers until after property changes have
completed and observers have been properly fired.