[BUGFIX release] Fix observer leaks #18767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
force-pushed
the
fix-mem-leak
branch
from
be634a7
to
9d0020d
Compare
rwjblue
reviewed
Feb 26, 2020
rwjblue
approved these changes
Feb 26, 2020
krisselden
force-pushed
the
fix-mem-leak
branch
2 times, most recently
from
b026d64
to
4a6dea5
Compare
rwjblue
approved these changes
Feb 26, 2020
krisselden
force-pushed
the
fix-mem-leak
branch
from
4a6dea5
to
d4d6abd
Compare
|
Could someone explain the scope of the bug this PR fixes? (And do we know what version introduced it?) I ask because I've been thinking about / looking into potential memory leaks in our app, and I could use any knowledge I can get :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.