Workaround for #15635 (integer encoding issue) #18730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
force-pushed
the
integers-test
branch
3 times, most recently
from
0d49231
to
a6cce3c
Compare
chancancode
commented
Feb 11, 2020
packages/ember-template-compiler/lib/plugins/safe-integers-bugfix.ts
Outdated
Show resolved
Hide resolved
chancancode
force-pushed
the
integers-test
branch
from
a6cce3c
to
b331602
Compare
chancancode
changed the title
btecu
reviewed
Feb 11, 2020
packages/ember-template-compiler/lib/plugins/safe-integers-bugfix.ts
Outdated
Show resolved
Hide resolved
chancancode
force-pushed
the
integers-test
branch
5 times, most recently
from
34d6b6e
to
c1c9d5b
Compare
rwjblue
approved these changes
Feb 11, 2020
rwjblue
approved these changes
Feb 11, 2020
krisselden
reviewed
Feb 11, 2020
krisselden
approved these changes
Feb 11, 2020
chancancode
force-pushed
the
integers-test
branch
from
c1c9d5b
to
218c261
Compare
Workaround for the Glimmer VM bug which encodes/decodes integer literals correctly. See #15635. Based on #18484 and #18484 (comment) Fixes #15635. Closes #18484. Co-authored-by: Saravana Kumar V <vsk62.gate@gmail.com>
chancancode
force-pushed
the
integers-test
branch
from
218c261
to
69fc6dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #18484 (comment)