[BUGFIX] Reverts the naming of setClassicDecorator externally #17833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buschtoens
approved these changes
Apr 2, 2019
|
ember-concurrency is currently broken in Ember Octane because of this. Thanks for fixing it so quickly! :) |
|
I currently do this to fix it: // @see https://github.com/emberjs/ember.js/pull/17833
if (!Ember._setComputedDecorator) {
Ember._setComputedDecorator = Ember._setClassicDecorator;
}// ember-cli-build.js
app.import('vendor/fix-decorator.js'); |
|
This broke Ember Data as well |
The rename was intended to be internal only, the external API is already in use so we should keep it as is. Name is unfortunate, but it kind of is either way.
pzuraq
force-pushed
the
bugfix/fix-set-computed-decorator
branch
from
91b6a33
to
d197d87
Compare
|
Just pushed an additional commit that deprecates instead. |
josemarluedke
added a commit
to josemarluedke/ember-decorators
that referenced
this pull request
Apr 3, 2019
This fixes the deprecation added in Ember by PR emberjs/ember.js#17833.
pzuraq
pushed a commit
to ember-decorators/ember-decorators
that referenced
this pull request
Apr 3, 2019
…tor (#424) This fixes the deprecation added in Ember by PR emberjs/ember.js#17833.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename was intended to be internal only, the external API is
already in use so we should keep it as is. Name is unfortunate, but
it kind of is either way.