Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] passing ObjectProxy with a property size to isEmpty would throw assertion #17570

Merged
merged 2 commits into from
Oct 16, 2021
Merged

[BUGFIX] passing ObjectProxy with a property size to isEmpty would throw assertion #17570

merged 2 commits into from
Oct 16, 2021

Conversation

nickschot
Copy link
Contributor

fixes #17032

@locks
Copy link
Contributor

locks commented Apr 19, 2020

Hi! Is this the same as #18882 ?

@nickschot
Copy link
Contributor Author

Hi! Is this the same as #18882 ?

It seems similar. Not sure if typeof obj.unknownProperty !== 'function' results in the same as typeof obj (which is what happens in the other PR) though?

@nickschot
Copy link
Contributor Author

@locks rebased!

@locks locks requested a review from rwjblue October 14, 2021 16:14
@locks locks merged commit b838c80 into emberjs:master Oct 16, 2021
@locks
Copy link
Contributor

locks commented Oct 16, 2021

Thank yoouu 😁

@nickschot nickschot deleted the fix-objectproxy-is-empty branch October 16, 2021 13:08
@jaredgalanis jaredgalanis mentioned this pull request Dec 30, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisselden krisselden Awaiting requested review from krisselden

@stefanpenner stefanpenner Awaiting requested review from stefanpenner

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isEmpty call on ProxyObject w/ size property throws '.get()' proxy assertion (3.1+)
2 participants
@nickschot @locks