Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] fix 'strict mode does not allow function declarations' #17426

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

stukalin
Copy link
Contributor

@stukalin stukalin commented Jan 4, 2019

We've discovered that on ios9 (at least) there is an error strict mode does not allow function declarations which prevents the application to work normally. We assume, although we're not quite sure, it was released with the v3.6.

Anyways, it's related to the fact that the function cleanURL was declared within an if block in the router.ts.

It turns out that the eslint rule which cares about such issues had been disabled. After re-enabling it I found out that there are only 2 issues (the one with the router and another one in the test).

I guess it's worth making the rule enabled; I also fixed the 2 failures by assigning functions to variables.

@rwjblue
Copy link
Member

rwjblue commented Jan 4, 2019

Good sleuthing, and thanks for fixing it!

@rwjblue rwjblue merged commit ad5f092 into emberjs:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants