Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove deprecated 'POSITIONAL_PARAM_CONFLICT' #17319

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

btecu
Copy link
Contributor

@btecu btecu commented Dec 9, 2018

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Dec 9, 2018

Thanks for picking this up @btecu!

@rwjblue
Copy link
Member

rwjblue commented Dec 9, 2018

Looks like a number of legit failures

@btecu btecu force-pushed the cleanup6 branch 3 times, most recently from fa5d014 to 948e971 Compare December 9, 2018 23:54
@btecu
Copy link
Contributor Author

btecu commented Dec 10, 2018

@rwjblue Can you take a look again? I'm not sure if this is the right approach.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks great to me!

@rwjblue rwjblue changed the title Remove deprecated 'POSITIONAL_PARAM_CONFLICT' [CLEANUP] Remove deprecated 'POSITIONAL_PARAM_CONFLICT' Dec 10, 2018
@rwjblue rwjblue merged commit c9e4818 into emberjs:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants