Cleanup array mixin #16718
Merged
Cleanup array mixin #16718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
commented
Jun 5, 2018
| @@ -936,17 +932,16 @@ const ArrayMixin = Mixin.create(Enumerable, { | |||
| @method reduce | |||
| @param {Function} callback The callback to execute | |||
| @param {Object} initialValue Initial value for the reduce | |||
| @param {String} reducerProperty internal use only. | |||
There was a problem hiding this comment.
reducerProperty seems not used anywhere and remains from SproutCore days I think
|
@mmun maybe you can review this ? |
rwjblue
reviewed
Jun 28, 2018
| }, this); | ||
|
|
||
| return ret; | ||
| return this.map(item => tryInvoke(item, methodName, args)); |
There was a problem hiding this comment.
This change breaks the API of invoke, which now no longer returns an Ember.A when prototype extensions are disabled.
There was a problem hiding this comment.
is wrapping it with Ember.A ok ? or revert will help ?
There was a problem hiding this comment.
I'm going to revert just this part, and add some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.