Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Bring back (with deprecation) Ember.EXTEND_PROTOTYPES. #16514

Merged
merged 1 commit into from
Apr 13, 2018
Merged

[BUGFIX beta] Bring back (with deprecation) Ember.EXTEND_PROTOTYPES. #16514

merged 1 commit into from
Apr 13, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 13, 2018

Fixes #16511

@rwjblue rwjblue merged commit c58044b into emberjs:master Apr 13, 2018
@rwjblue rwjblue deleted the fix-extend-prototypes branch April 13, 2018 20:16
@kiwiupover kiwiupover mentioned this pull request Apr 13, 2018
Closed
@ursm ursm mentioned this pull request Apr 14, 2018
Merged
@ursm
Copy link
Contributor

ursm commented Apr 14, 2018

@rwjblue
This fix seems to be causing an error. Would you confirm it?

Uncaught Error: Assertion Failed: When calling `deprecate` you must provide an `options` hash as the third parameter.  `options` should include `id` and `until` properties.

@rwjblue
Copy link
Member Author

rwjblue commented Apr 14, 2018

Yep. You are correct 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @ursm