Iterable refactor #16399
Merged
Iterable refactor #16399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirement is that they support `Symbol.iterator`. The browsers that don't support are Internet Explorer and phantomjs, every other browser does. One caveat of this feature is that iterables are not observables, so each cannot track updates to them, but the code is structured on a way that this branch is a fallback, so all special cases where KVO is possible are handled as they where before.
chancancode
force-pushed
the
iterable-refactor
branch
from
d98366c
to
dd3b21c
Compare
- Merge native iterable tests to use shared test cases - Refactor iterable implementations, fix missing/wrong types and type errors - Introduce `key="@key"` for `{{#each-in}}` (the default) - Make `key="@Index"` actually use the index in `{{#each-in}}` - Add support for native iterables and `forEach` in `{{#each-in}}`
chancancode
force-pushed
the
iterable-refactor
branch
from
dd3b21c
to
1d0ef5f
Compare
mmun
approved these changes
Mar 23, 2018
This was referenced Mar 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need tests for
{{#each-in}}+Symbol.iterator/forEach