[BUGIFX] link-to active class applied when params change #16117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
force-pushed
the
active-class-on-params-change
branch
from
1979022
to
1facdd0
Compare
jasonmit
force-pushed
the
active-class-on-params-change
branch
from
1facdd0
to
9b6c349
Compare
rwjblue
approved these changes
Jan 12, 2018
|
I believe this will need to be pulled all the way down into |
|
Thank you @jasonmit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #16060
(Sorry for not reusing original PR, github bug).
Prior to 2.18.0, the link-to component would recompute
active/_activewhenattrs.paramschanged. It no longer behaves this way, this patch reverts back to the prior link-to behavior.Changing
dynamicRoutewill not cause the link-to to recompute whether it's active or not./cc @thoov @rwjblue <3