Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for RFC 176 syntax and canonical URL #16113

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Update docs for RFC 176 syntax and canonical URL #16113

merged 1 commit into from
Jan 12, 2018

Conversation

williamhaley
Copy link
Contributor

#15723 Update ember-debug package to use rfc176 imports/naming conventions and update doc URLs to use ../release/.. for canonical path

@@ -55,27 +55,27 @@ moduleFor('ember-debug', class extends TestCase {
ENV._ENABLE_DEPRECATION_OPTIONS_SUPPORT = originalDeprecationOptions;
}

['@test Ember.deprecate does not throw if RAISE_ON_DEPRECATION is false'](assert) {
['@test deprecate does not throw if RAISE_ON_DEPRECATION is false'](assert) {
Copy link
Contributor Author

@williamhaley williamhaley Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating names in tests wasn't in the scope original issue, but I figured I could update them while I was in there. I'm happy to revert these though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its what I was trying to say here, so yes, you are on the right track:

Additionally we'd like to convert references to old Ember namespaced classes to their simplified post RFC 176 names.
(example: documentation might refer to Ember.Object, while we'd want it to be EmberObject now)
See the readme for https://github.com/ember-cli/ember-rfc176-data for the mappings.

@toddjordan
Copy link
Contributor

This looks great. Thanks, @williamhaley !

@toddjordan
Copy link
Contributor

@williamhaley Could you reword the commit prepend [doc beta], so we can get this into 3.0?
See https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md#documentation
(I'll also update the issue)

@williamhaley
Copy link
Contributor Author

@toddjordan commit tag updated 👍

@toddjordan toddjordan merged commit ee85052 into emberjs:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants