Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] bump route-recognizer to v0.3.3 #15218

Merged
merged 2 commits into from
May 9, 2017

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented May 9, 2017

TL;DR this reduces the number of arrays route-recognizer allocates dramatically, but should not include any observable feature changes.

@stefanpenner stefanpenner requested a review from rwjblue May 9, 2017 17:24
@rwjblue
Copy link
Member

rwjblue commented May 9, 2017

Looks like some possibly related failures:

Test failed: Query Params - main:  Defaulting to params hash as the model should not result in that params object being watched
    Failed assertion: Promise rejected during  Defaulting to params hash as the model should not result in that params object being watched: Attempting to define property on object that is not extensible.
	at defineProperty ([native code])
	at Fallback_setMeta (http://localhost:13141/ember.debug.js:24553:32)
	at meta (http://localhost:13141/ember.debug.js:24611:12)
	at model (http://localhost:13141/ember-tests.js:74091:40)
	at deserialize (http://localhost:13141/ember.debug.js:32033:24)
	at applyHook (http://localhost:13141/ember.debug.js:50083:34)
	at runSharedModelHook (http://localhost:13141/ember.debug.js:50668:29)
	at getModel (http://localhost:13141/ember.debug.js:50866:37)

@stefanpenner
Copy link
Member Author

stefanpenner commented May 9, 2017

Looks like some possibly related failures:

Ya that one kinda makes sense, we should likely improve are ability to work with frozen objects and stuff. Taking a look now.

Seems to be something funky in phantom :(

@stefanpenner
Copy link
Member Author

@rwjblue I believe the non-weakmap path for setting meta is not aware of frozen objects. I think that is a bug, so I'll go and explore fixing that now.

@stefanpenner
Copy link
Member Author

@rwjblue I have updated the test to pass, and as a bonus, it now tests what its assertion message claims directly.

@stefanpenner
Copy link
Member Author

for anyone interested the test was introduced: 6a7b7cd

@stefanpenner stefanpenner merged commit 229f92a into master May 9, 2017
@stefanpenner stefanpenner deleted the bump-route-recognizer branch May 9, 2017 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants