Add failing test for query params replace and refreshModel not working together #15148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note - the tests are supposed to fail at the moment, this requires a new release of router.js and then bumping the version in package.json for the test to pass (checked locally that this resolves this issue, which it does and doesn't cause any other test failures) |
|
@alexspeller - Mind rebasing, so we can land this? I think the recent bump to router_js@1.2.7 should unblock... |
alexspeller
force-pushed
the
query-params-refreshModel-replace-failing-test
branch
from
1e0a26a
to
67d3f4f
Compare
|
Thanks again @alexspeller! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add failing test for query params not working with both replace and refreshModel
Ember issue: #11843
Resolved by: tildeio/router.js#210