[PERF/Correctness] Remove global didDefineProperty #15141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanpenner
commented
Apr 14, 2017
stefanpenner
commented
- removes an extra mixin from all Object Hierarchies
- only runs when actually defining a CP if actually defining a new computed property.
- misc cleanup
|
test failure was just yarn, giving it another kick |
|
This may also be a |
* removes an extra mixin from all Object Hierarchies * only runs when actually defining a CP if actually defining a new computed property. * misc cleanup
stefanpenner
force-pushed
the
remove-cp-cache-busting-mixin
branch
from
b95ebf6 to
ecff7b8
Compare
|
LGTM @krisselden - r? |
rwjblue
approved these changes
Apr 14, 2017
|
When things are labelled perf we should try to include some reference to benchmark for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.